Add tensorboard to display training and evaluation metrics #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 8, 2025
… implementation to support DLRMv2 (pytorch#3163) Summary: Pull Request resolved: pytorch#3163 ### Major changes - Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`. - Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`. - Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method. - Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name. Rollback Plan: Differential Revision: D77841795
lizhouyu
force-pushed
the
export-D77841795
branch
from
c96a893 to
f120f53
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
lizhouyu
force-pushed
the
export-D77841795
branch
from
f120f53 to
20ce4f0
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 9, 2025
… implementation to support DLRMv2 (pytorch#3163) Summary: Pull Request resolved: pytorch#3163 ### Major changes - Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`. - Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`. - Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method. - Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name. - Revise DLRMv2 configuration yaml file to set table size for each feature. - Revise the default value for "num_embeddings" parameter in `arguments.py` to None. Rollback Plan: Differential Revision: D77841795
Summary: Pull Request resolved: pytorch#3127 Differential Revision: D77033290
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
lizhouyu
force-pushed
the
export-D77841795
branch
from
20ce4f0 to
38b0865
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 14, 2025
… implementation to support DLRMv2 (pytorch#3163) Summary: Pull Request resolved: pytorch#3163 ### Major changes - Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`. - Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`. - Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method. - Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name. - Revise DLRMv2 configuration yaml file to set table size for each feature. - Revise the default value for "num_embeddings" parameter in `arguments.py` to None. Rollback Plan: Differential Revision: D77841795
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 14, 2025
… implementation to support DLRMv2 (pytorch#3163) Summary: Pull Request resolved: pytorch#3163 ### Major changes - Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`. - Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`. - Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method. - Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name. - Revise DLRMv2 configuration yaml file to set table size for each feature. - Revise the default value for "num_embeddings" parameter in `arguments.py` to None. Differential Revision: D77841795
lizhouyu
force-pushed
the
export-D77841795
branch
from
38b0865 to
30f42a3
Compare
… implementation to support DLRMv2 (pytorch#3163) Summary: Pull Request resolved: pytorch#3163 ### Major changes - Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`. - Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`. - Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method. - Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name. - Revise DLRMv2 configuration yaml file to set table size for each feature. - Revise the default value for "num_embeddings" parameter in `arguments.py` to None. Differential Revision: D77841795
|
This pull request was exported from Phabricator. Differential Revision: D77841795 |
lizhouyu
force-pushed
the
export-D77841795
branch
from
30f42a3 to
3ba83dc
Compare
|
Hi @lizhouyu! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77841795